New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: don't use strlen in constexprs to not break Clang builds. #15688

Merged
merged 1 commit into from Jun 14, 2017

Conversation

Projects
None yet
3 participants
@rzarzynski
Contributor

rzarzynski commented Jun 14, 2017

@wjwithagen: could you please take a look?

rgw: don't use strlen in constexprs to not brake Clang builds.
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jun 14, 2017

From Clang build 796:

/home/jenkins/workspace/ceph-master/src/rgw/rgw_auth_s3.h:171:29: error: constexpr variable cannot have non-literal type 'const string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >')
    static constexpr string META_MAX_SIZE_STR = "\r\nffffffffffffffff;chunk-signature=";

Hmm, this looks like something different. META_MAX_SIZE_STR isn't in my tree. Was it introduced by your patches?

@wjwithagen wjwithagen self-requested a review Jun 14, 2017

@wjwithagen

Compiles fine under Clang

@wjwithagen wjwithagen added the needs-qa label Jun 14, 2017

@oritwas oritwas merged commit b4e75a3 into ceph:master Jun 14, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details

@theanalyst theanalyst changed the title from rgw: don't use strlen in constexprs to not brake Clang builds. to rgw: don't use strlen in constexprs to not break Clang builds. Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment