New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: raise python exception on failure in send_command() #15704

Merged
merged 2 commits into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jun 15, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

mgr: raise python exception on failure in send_command()
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the mgr label Jun 15, 2017

@tchaikov tchaikov requested review from liewegas and jcsp Jun 15, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 15, 2017

mon/OSDMonitor: more assert()
this helps with silencing the clang analyzer also.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@@ -7090,7 +7090,7 @@ int OSDMonitor::prepare_command_osd_destroy(
// defying PaxosService and all laws of nature. Therefore, as we may
// be used during 'osd purge', let's keep the caller responsible for
// proposing.
assert(err == 0);

This comment has been minimized.

@tchaikov

tchaikov Jun 15, 2017

Contributor

@badone this silences some clang analyzer warnings.

This comment has been minimized.

@badone

badone Jun 15, 2017

Contributor

Nice!

@liewegas liewegas added the needs-qa label Jun 15, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 16, 2017

@tchaikov tchaikov merged commit 25576bb into ceph:master Jun 16, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-mgr-raise-in-send-command branch Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment