New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: load log lines on startup, split out audit log #15709

Merged
merged 3 commits into from Jun 20, 2017

Conversation

Projects
None yet
4 participants
@jcsp
Contributor

jcsp commented Jun 15, 2017

Previously only saw log lines output after
the module had loaded: now we have log last,
let's use it!

Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp added the mgr label Jun 15, 2017

@jcsp jcsp changed the title from [DNM] mgr/dashboard: load log lines on startup to mgr/dashboard: load log lines on startup, split out audit log Jun 15, 2017

@jcsp jcsp requested review from liewegas and tchaikov Jun 15, 2017

@liewegas

yes!

jcsp added some commits Jun 15, 2017

mgr/dashboard: load log lines on startup, separate audit
Previously only saw log lines output after
the module had loaded: now we have `log last`,
let's use it!

Signed-off-by: John Spray <john.spray@redhat.com>
mon: more power for "profile mgr"
mgr modules are meant to be able to do management
type operations, even though they're mostly currently
doing monitoring.

Signed-off-by: John Spray <john.spray@redhat.com>
mgr/dashboard: split out audit log messages in UI
Signed-off-by: John Spray <john.spray@redhat.com>

@liewegas liewegas added the needs-qa label Jun 16, 2017

# Oh well. We won't let this stop us though.
self.log.error("Error fetching log history (r={0}, \"{1}\")".format(
r, outs))
else:

This comment has been minimized.

@tchaikov

tchaikov Jun 16, 2017

Contributor

nit, could early return to reduce the indent level. also shall we set self.log_primed if log last fails?

@yuriw

This comment has been minimized.

Contributor

yuriw commented Jun 19, 2017

test this please

@liewegas liewegas merged commit 853a54a into ceph:master Jun 20, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment