New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/cephfs: remove `apply` mode of cephfs-journal-tool #15715

Merged
merged 1 commit into from Jun 21, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Jun 15, 2017

This is undocumented and untested -- it was something
written before and superceded by the "recover_dentries"
subcommand. While we're at it, also
s/scavenge_dentries/recover_dentries/
internally.

Signed-off-by: John Spray john.spray@redhat.com

John Spray
tools/cephfs: remove `apply` mode of cephfs-journal-tool
This is undocumented and untested -- it was something
written before and superceded by the "recover_dentries"
subcommand.  While we're at it, also
s/scavenge_dentries/recover_dentries/
internally.

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp requested a review from batrick Jun 15, 2017

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jun 17, 2017

retest this please

@batrick

This comment has been minimized.

Member

batrick commented Jun 21, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@jcsp jcsp merged commit 623e8b2 into ceph:master Jun 21, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details

@jcsp jcsp deleted the jcsp:wip-jt-rmapply branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment