New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/BlueStore: no device no symlink. #15721

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@majianpeng
Copy link
Member

majianpeng commented Jun 16, 2017

If bluestore_block_db_create or bluestore_block_db_create is false and
we use non-exist blockdevice as db/wal. ceph-osd still work and it use
block as db/wal. This bug introduced by 316810d.

If stat(symlink) error and symlink still exist, this is bug.

Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com

bluefs_shared_bdev = BlueFS::BDEV_DB;
} else {
//symlink exist is bug
derr << __func__ << " " << bfn << " link target don't exist" << dendl;

This comment has been minimized.

@xiexingguo

xiexingguo Jun 16, 2017

Member

s/don't/doesn't/

@majianpeng majianpeng force-pushed the majianpeng:bluestore-nodevice-nosymlink branch from ab5e454 to 35e75bd Jun 16, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jun 16, 2017

retest this please

os/bluestore/BlueStore: no device no symlink.
If bluestore_block_db_create or bluestore_block_db_create is false
and we use non-exist blockdevice as db/wal. ceph-osd still work and it
use block as db/wal. This bug introduced by 316810d.

If stat(symlink) error and symlink still exist, this is bug.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@liewegas liewegas merged commit 0ed708a into ceph:master Jun 16, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment