New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: Log errors at startup #15723

Merged
merged 1 commit into from Jun 21, 2017

Conversation

Projects
None yet
5 participants
@badone
Contributor

badone commented Jun 16, 2017

Currently we send error messages to stderr but these tend to be
swallowed up by the init scripts. Send error messages to derr instead so
they go to both stderr and the cluster log.

Fixes: http://tracker.ceph.com/issues/14088

Signed-off-by: Brad Hubbard bhubbard@redhat.com

badone added a commit to badone/ceph that referenced this pull request Jun 16, 2017

mon: Log errors at startup
Currently we send error messages to stderr but these tend to be
swallowed up by the init scripts. Send error messages to derr instead so
they go to both stderr and the cluster log.

Fixes: ceph#15723

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
mon: Log errors at startup
Currently we send error messages to stderr but these tend to be
swallowed up by the init scripts. Send error messages to derr instead so
they go to both stderr and the cluster log.

Fixes: http://tracker.ceph.com/issues/14088

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@alfredodeza

This comment has been minimized.

Contributor

alfredodeza commented Jun 16, 2017

@badone does journalctl -xe or systemctl status ceph-mon doesn't show the output? That is how I've dealt with ceph-osd daemons having issues when starting up. How are the init scripts eating that output?

@badone

This comment has been minimized.

Contributor

badone commented Jun 16, 2017

@alfredodeza Well, it's more about the user experience than anything. The mon log is where users expect to see output from the mon and not having it leads to a user experience like https://www.spinics.net/lists/ceph-devel/msg27762.html

It does make the problem easier to find so, unless there's a reason not to send the output to the log I think it's reasonable to do so. It still goes to stderr as well so anyone who wants to do the journalctl dance can still do so.

Jenkins retest this please.

@jdurgin jdurgin added needs-qa and removed needs-review labels Jun 20, 2017

@yuriw yuriw merged commit 88fe387 into ceph:master Jun 21, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment