New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: fix issues with image removal state machine #15734

Merged
merged 3 commits into from Jun 21, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Jun 16, 2017

No description provided.

@trociny

@dillaman LGTM, just a couple of suggestions that may be ignored.

}
if (!*result) {
if (!r) {

This comment has been minimized.

@trociny

trociny Jun 20, 2017

Contributor

nit: 'r == 0'?

if ((*result < 0) && (*result != -ENOENT)) {
lderr(m_cct) << "error fetching image name: " << cpp_strerror(*result)
if ((r < 0) && (r != -ENOENT)) {

This comment has been minimized.

@trociny

trociny Jun 20, 2017

Contributor

nit: it looks like usually we don't use extra parenthesis when it is not necessary. May be change this too while you cleaning this up?

dillaman added some commits Jun 16, 2017

librbd: remove state machine should ignore group not supported errors
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: clean up remove request state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: removed synchronous watcher check from remove image state mac…
…hine

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman

This comment has been minimized.

Contributor

dillaman commented Jun 20, 2017

@trociny update pushed

@trociny trociny merged commit 039b74d into ceph:master Jun 21, 2017

3 of 4 checks passed

arm64 make check arm64 make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-librbd-image-remove branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment