New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Changes for s3test config file, to add user under a tenant. #15753

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
4 participants
@pritha-srivastava
Contributor

pritha-srivastava commented Jun 19, 2017

Signed-off-by: Pritha Srivastava prsrivas@redhat.com

@pritha-srivastava

This comment has been minimized.

Contributor

pritha-srivastava commented Jun 19, 2017

@cbodley , @oritwas : Can you please review the changes to add a new section for a user under a tenant, needed for bucket policy tests. The actual change is a one line change. The other changes are to make teuthology pick my local s3tests branch, and will be removed later.

@pritha-srivastava

This comment has been minimized.

Contributor

pritha-srivastava commented Jun 19, 2017

http://pulpito.ceph.com/prsrivas-2017-06-14_10:53:30-rgw-wip-rgw-s3tests-conf---basic-smithi/ is the latest teuthology run, which has all the bucket policy related tests passing. The other failures are unrelated and are there in the master branch also

@@ -4,7 +4,8 @@ tasks:
- rgw: [client.0]
- s3tests:
client.0:
force-branch: ceph-master
git_remote: git://github.com/pritha-srivastava/

This comment has been minimized.

@oritwas

oritwas Jun 19, 2017

Contributor

Make sure those lines are not merged ...

This comment has been minimized.

@pritha-srivastava

pritha-srivastava Jun 19, 2017

Contributor

Yes, I need to remove this

ctx.cluster.only(client).run(
args=[
'git', 'clone',
'-b', branch,
teuth_config.ceph_git_base_url + 's3-tests.git',
git_remote + 's3-tests.git',

This comment has been minimized.

@oritwas

oritwas Jun 19, 2017

Contributor

I would not merge this either (in any case this needs to be checked to see if it work without supplying git_remote)

This comment has been minimized.

@pritha-srivastava

pritha-srivastava Jun 19, 2017

Contributor

I need to remove this also. This was put in to pick up my local s3tests branch.

This comment has been minimized.

@cbodley

cbodley Jun 19, 2017

Contributor

i think it would be useful to include this part, since this is the second PR that needed it (after #15115 from @theanalyst)

This comment has been minimized.

@theanalyst

theanalyst Jun 19, 2017

Member

yeah I have used that to test my tagging PR as well once just to make sure that the special s3tests branch passed in teuthology too.. here is a seperate commit that adds that 9944aad

This comment has been minimized.

@theanalyst

theanalyst Jun 19, 2017

Member

alternatively merging this PR minus the git_remote would also work :)

This comment has been minimized.

@pritha-srivastava

pritha-srivastava Jun 19, 2017

Contributor

Ok, I'll leave this out, since @theanalyst already has a separate PR for it.

This comment has been minimized.

@theanalyst

theanalyst Jun 19, 2017

Member

@pritha-srivastava no I don't have a PR, this was just a commit in an older PR, its good to get it in this PR itself (and by this, earlier I meant your current PR ), so no need to leave this out..

This comment has been minimized.

@pritha-srivastava

pritha-srivastava Jun 19, 2017

Contributor

oh ok, i'll leave it in there then.

rgw: Changes for s3test config file, to add user under a tenant.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
@pritha-srivastava

This comment has been minimized.

Contributor

pritha-srivastava commented Jun 21, 2017

@cbodley @oritwas : I have updated the PR. Please take a look. The changes related to git_remote havent caused any failures apart from the ones already present on master: http://pulpito.ceph.com/prsrivas-2017-06-20_09:12:26-rgw-wip-rgw-s3tests-conf---basic-smithi/

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 21, 2017

@pritha-srivastava looks good to me 👍

i'll let @oritwas decide about the git_remote part

@oritwas

This comment has been minimized.

Contributor

oritwas commented Jun 22, 2017

@pritha-srivastava , as the git-remote had testing I approve

@oritwas oritwas merged commit c320fbd into ceph:master Jun 22, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment