New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: automatically set RDMAV_HUGEPAGES_SAFE according to conf #15755

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
4 participants
@Adirl

Adirl commented Jun 19, 2017

Signed-off-by: DanielBar-On danielbo@mellanox.com

@Adirl

This comment has been minimized.

Adirl commented Jun 19, 2017

@yuyuyu101
please take a look

int rc = ibv_fork_init();
if (rc) {
lderr(cct) << __func__ << " failed to call ibv_for_init(). On RDMA must be called before fork. Application aborts." << dendl;
ceph_abort();
}
ldout(cct, 20) << __func__ << " ms_async_rdma_enable_hugepage value is: " << cct->_conf->ms_async_rdma_enable_hugepage << dendl;
if (cct->_conf->ms_async_rdma_enable_hugepage){

This comment has been minimized.

@yuyuyu101

yuyuyu101 Jun 19, 2017

Member

blank before bracket

@@ -548,6 +559,10 @@ RDMAStack::RDMAStack(CephContext *cct, const string &t): NetworkStack(cct, t)
RDMAStack::~RDMAStack()
{
if (cct->_conf->ms_async_rdma_enable_hugepage){

This comment has been minimized.

@yuyuyu101

yuyuyu101 Jun 19, 2017

Member

ditto

ldout(cct, 20) << __func__ << " ms_async_rdma_enable_hugepage value is: " << cct->_conf->ms_async_rdma_enable_hugepage << dendl;
if (cct->_conf->ms_async_rdma_enable_hugepage){
rc = setenv("RDMAV_HUGEPAGES_SAFE","1",1);
ldout(cct, 20) << __func__ << " RDMAV_HUGEPAGES_SAFE is set as: " << getenv("RDMAV_HUGEPAGES_SAFE") << dendl;

This comment has been minimized.

@yuyuyu101

yuyuyu101 Jun 19, 2017

Member

ldout(cct, 1) should be better

msg/async/rdma: automatically set RDMAV_HUGEPAGES_SAFE according to conf
Signed-off-by: DanielBar-On <danielbo@mellanox.com>
@Adirl

This comment has been minimized.

Adirl commented Jun 20, 2017

@yuyuyu101
Done

@yuyuyu101 yuyuyu101 requested a review from tchaikov Jun 20, 2017

@Adirl

This comment has been minimized.

Adirl commented Jun 21, 2017

@yuyuyu101 yuyuyu101 merged commit 49fe721 into ceph:master Jun 22, 2017

3 of 4 checks passed

arm64 make check arm64 make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@Adirl Adirl deleted the Adirl:wip-HUGEPAGES branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment