New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/filestore: call committed_thru when no journal entries are replayed #15781

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@kchiu
Contributor

kchiu commented Jun 20, 2017

As described in commit message of 8924158, we should call committed_thru
when no journal entries are replayed in case journal is full but not
trimmed yet.

Signed-off-by: Kuan-Kai Chiu big.chiu@bigtera.com

os/filestore: call committed_thru when no journal entries are replayed
As described in commit message of 8924158, we should call committed_thru
when no journal entries are replayed in case journal is full but not
trimmed yet.

Signed-off-by: Kuan-Kai Chiu <big.chiu@bigtera.com>
@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jun 20, 2017

I don't have much experience in FileStore, but I'm a little confused. Is this a newly-introduced bug from somewhere? Something that got missed in the referenced commit? Are you moving functionality around so it applies to non-FileJournal implementations?

@kchiu

This comment has been minimized.

Contributor

kchiu commented Jun 29, 2017

I think 8924158 missed the committed_thru call, so it didn't solve the bug as it described. During osd start, if the file journal is full but all its entries had been committed to the underlying backend, the journal will be full forever. We need to call committed_thru explicitly to reset header.start so the journal will have room to write.

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jun 29, 2017

This will need attention from somebody more familiar with FileStore, or at least the time to dig into it.

@liewegas liewegas merged commit ac49436 into ceph:master Jul 7, 2017

3 of 4 checks passed

arm64 make check arm64 make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment