New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: do not add dependencies to INTERFACE library on cmake < 3.3 #15813

Merged
merged 1 commit into from Jun 21, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jun 21, 2017

otherwise we will have

add_dependencies Cannot add target-level dependencies to INTERFACE
library

Signed-off-by: Kefu Chai kchai@redhat.com

cmake: do not add dependencies to INTERFACE library on cmake < 3.3
otherwise we will have

add_dependencies Cannot add target-level dependencies to INTERFACE
library

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from jecluis Jun 21, 2017

@jecluis

do_cmake.sh is now finishing for me with cmake 3.0.2. Thanks!

@tchaikov tchaikov merged commit b85e572 into ceph:master Jun 21, 2017

2 of 4 checks passed

make check make check failed
Details
arm64 make check arm64 make check started
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-cmake branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment