New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: slightly refactor Blob::try_reuse_blob #15836

Merged
merged 3 commits into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Jun 22, 2017

(1) rename try_reuse_blob->can_reuse_blob to keep pace with
can_split/can_split_at.
(2) replace blob with get_blob().

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jun 22, 2017

Member

@ifed01 Igor, I slightly refactor the try_reuse_blob method.

Mind having a look?

Member

xiexingguo commented Jun 22, 2017

@ifed01 Igor, I slightly refactor the try_reuse_blob method.

Mind having a look?

@xiexingguo xiexingguo requested a review from ifed01 Jun 22, 2017

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jun 23, 2017

Member

@ifed01 Updated! Can you recheck?

Member

xiexingguo commented Jun 23, 2017

@ifed01 Updated! Can you recheck?

@liewegas liewegas added the needs-qa label Jun 27, 2017

@ifed01

ifed01 approved these changes Jun 27, 2017

@ifed01

This comment has been minimized.

Show comment
Hide comment
@ifed01

ifed01 Jun 27, 2017

Contributor

and please replace "(2) use blob directly." in the commit message...

Contributor

ifed01 commented Jun 27, 2017

and please replace "(2) use blob directly." in the commit message...

xiexingguo added some commits Jun 22, 2017

os/bluestore: slightly refactor Blob::try_reuse_blob
(1) rename try_reuse_blob->can_reuse_blob to keep pace with
can_split/can_split_at.
(2) replace blob with get_blob().

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
os/bluestore: spaces
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
os/bluestore: add sanity check to seq_bytes
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@liewegas liewegas merged commit 0e9971c into ceph:master Jul 11, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-refactor-try-reuse-blob branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment