New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix err when copy object in bucket with specified placement rule #15837

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@fangyuxiangGL
Contributor

fangyuxiangGL commented Jun 22, 2017

rgw_obj_select copy constructor forgot placement_rule

Fixes: http://tracker.ceph.com/issues/20378

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Jun 22, 2017

Hi @yehudasa

could you review this? thanks

@joscollin joscollin requested a review from yehudasa Jun 22, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented Jun 22, 2017

Jenkins Retest this please

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Jun 27, 2017

hi @cbodley

could you have a look? thanks

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 28, 2017

jenkins test this please

2 similar comments
@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 6, 2017

jenkins test this please

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 7, 2017

jenkins test this please

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Jul 13, 2017

rebase again. hope no complain!

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Jul 13, 2017

@cbodley

always make check failed, even rebase..

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 13, 2017

@fangyuxiangGL It fails for all the PRs today. Wait for sometime or check tomorrow.

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Jul 13, 2017

@joscollin got it, thanks

@yuriw

This comment has been minimized.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 17, 2017

jenkins test this please

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 18, 2017

jenkins retest this please

@cbodley cbodley merged commit d91f57c into ceph:master Jul 18, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@fangyuxiangGL fangyuxiangGL deleted the fangyuxiangGL:placement-rule-err branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment