New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages/MOSDPing.h: drop unused fields #15843

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@branch-predictor
Member

branch-predictor commented Jun 22, 2017

For luminous, let's drop unused peer_as_of_epoch and peer_stat fields
from MOSDPing message.
Followup to #15727, not meant to be backported.

Signed-off-by: Piotr Dałek piotr.dalek@corp.ovh.com

qa

  • rados
  • upgrade/jewel-x
messages/MOSDPing.h: drop unused fields
For luminous, let's drop unused peer_as_of_epoch and peer_stat fields
from MOSDPing message.

Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
@gregsfortytwo

Reviewed-by: Greg Farnum gfarnum@redhat.com

// with luminous, we drop peer_as_of_epoch and peer_stat
if (!HAVE_FEATURE(features, SERVER_LUMINOUS)) {
epoch_t dummy_epoch = {};
osd_peer_stat_t dummy_stat = {};

This comment has been minimized.

@gregsfortytwo

gregsfortytwo Jun 22, 2017

Member

Is there a reason you're doing the funny initializer?

Yeah, "funny initializer" is how much of some of the newer stuff I really grok. :(

@branch-predictor

This comment has been minimized.

Member

branch-predictor commented Jun 26, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 5, 2017

looks ok in rados, http://pulpito.ceph.com/sage-2017-07-03_15:41:59-rados-wip-sage-testing-distro-basic-smithi/
needs upgrade suite since rados/upgrade is broken

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 12, 2017

@liewegas liewegas merged commit 36698ad into ceph:master Jul 12, 2017

3 of 4 checks passed

arm64 make check arm64 make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@branch-predictor branch-predictor deleted the ovh:bp-drop-ping-fields branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment