New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/vstart.sh: kill dead upmap option #15848

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@xiexingguo
Member

xiexingguo commented Jun 22, 2017

So we won't be prevented from use the new "pg upmap" command.

E.g.:
~# ./bin/ceph osd pg-upmap-items 0.7 0 1
Error EPERM: min_compat_client jewel < luminous, which is required for pg-upmap
@@ -321,7 +321,6 @@ OPTION(mon_cache_target_full_warn_ratio, OPT_FLOAT, .66) // position between poo
OPTION(mon_osd_full_ratio, OPT_FLOAT, .95) // what % full makes an OSD "full"
OPTION(mon_osd_backfillfull_ratio, OPT_FLOAT, .90) // what % full makes an OSD backfill full (backfill halted)
OPTION(mon_osd_nearfull_ratio, OPT_FLOAT, .85) // what % full makes an OSD near full
OPTION(mon_osd_initial_require_min_compat_client, OPT_STR, "jewel")

This comment has been minimized.

@liewegas

liewegas Jun 22, 2017

Member

IMO if we want to change this we should switch the config to 'luminous' instead of 'jewel'.

...but I think we should leave this at jewel since even the latest kernel client doesn't yet support upmap.

src/vstart.sh: kill dead upmap option
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo changed the title from mon/OSDMonitor: bump up require_min_compat_client for new cluster to src/vstart.sh: kill dead upmap option Jun 22, 2017

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jun 22, 2017

...but I think we should leave this at jewel since even the latest kernel client doesn't yet support upmap.

I think you are right. We might use "osd set-require-min-compat-client" to update this if we can confirm that upmap is fully understood by clients.

Drop that change and leave the cleanup change only.

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jun 23, 2017

@liewegas ping?

@liewegas liewegas merged commit eb61a97 into ceph:master Jun 23, 2017

2 of 4 checks passed

arm64 make check arm64 make check failed
Details
make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-fix-rmcc branch Jun 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment