New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth/RotatingKeyRing: use std::move() to set secrets #15866

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jun 23, 2017

the param will be thrown away anyway. see
CephxClientHandler::handle_response().

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from liewegas and cbodley Jun 23, 2017

@@ -24,7 +24,7 @@ bool RotatingKeyRing::need_new_secrets(utime_t now) const
void RotatingKeyRing::set_secrets(RotatingSecrets& s)
{
Mutex::Locker l(lock);
secrets = s;

This comment has been minimized.

@yuyuyu101

yuyuyu101 Jun 23, 2017

Member

it would be better to be explicit. RotatingSecrets&& s

This comment has been minimized.

@tchaikov

tchaikov Jun 23, 2017

Contributor

fixed and repushed

auth/RotatingKeyRing: use std::move() to set secrets
the param will be thrown away anyway. see
CephxClientHandler::handle_response().

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit d9e4288 into ceph:master Jun 26, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-set-secrets branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment