New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vstart.sh: Work around mgr restfull not available #15877

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@wjwithagen
Contributor

wjwithagen commented Jun 23, 2017

  • Since the only effect is writting a CERT to the stdout, it might
    suffice to just make this result optional and not err-out on this
    in vstart.
    Tests that are using this functionality/cert should perhaPs generate
    it themselves.

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

./src/vstart.sh: Work around mgr restfull not available
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Jun 23, 2017

@liewegas @tchaikov
My Jenkins testrun got bitten once more by restful not available in the setup of the VM.
So perhpas we should allow that and just make it a warning.
Looks like the CERT is only written to stdout for the user to notice and perhaps work with it.

@wjwithagen wjwithagen changed the title from ./src/vstart.sh: Work around mgr restfull not available to vstart.sh: Work around mgr restfull not available Jun 23, 2017

@liewegas liewegas merged commit f6a49b7 into ceph:master Jun 23, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment