New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fixes for AWSBrowserUploadAbstractor auth #15882

Merged
merged 2 commits into from Jun 27, 2017

Conversation

Projects
None yet
3 participants
@rzarzynski
Contributor

rzarzynski commented Jun 23, 2017

This PR is an enhanced version of #15854.

cbodley and others added some commits Jun 22, 2017

rgw: fixes for AWSBrowserUploadAbstractor auth
return initializer lists rather than std::make_tuple(), which constructs
a temporary tuple and converts it to the return type. this was causing
an issue with std::string -> string_view conversions, because the
string_views ended up pointing to memory from a string in that
temporary tuple

Fixes: http://tracker.ceph.com/issues/20372

Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: use a struct instead of std::tuple in AWS's VersionAbstractor.
The C++11 standard mandates the variadic constructor of std::tuple
to be explicit. As a result, we can't use the uniform initialization
syntax in return statements. Moreover, the tuples became too verbose
after the AWSv4 rework.

See: https://stackoverflow.com/a/14961849
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 23, 2017

jenkins test this please

@yuriw yuriw merged commit a73f81b into ceph:master Jun 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment