New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, ceph-osdomap-tool: kill clang warnings #15905

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jun 25, 2017

No description provided.

tchaikov added some commits Jun 25, 2017

test/test_async_driver: silence clang static analyzer warning
* silence the warning of: Value stored to 'r' is never read
* update the gtest assertions to be semantically more correct.

Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph-osdomap-tool: early return and remove never-read store statement
* silence clang analyzer's warning of: "Value stored to 'r' is never
  read"
* replace the "goto" statement with early return to improve the
  readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit e34a379 into ceph:master Jun 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-kill-clang-warnings branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment