Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/OSD: add more useful perf counters for performance tuning. #15915

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
2 participants
@liupan1111
Copy link
Contributor

liupan1111 commented Jun 26, 2017

  1. add perf counters for the latency before enqueue_op and dequeue_op
  2. add max latency to tune the latency of op_wq.pause. If this max latency is too long, it may cause osd_op_tp thread timeout, and OSD unhealthy.

Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com

@liupan1111 liupan1111 requested a review from liewegas Jun 26, 2017

@liupan1111

This comment has been minimized.

Copy link
Contributor Author

liupan1111 commented Jun 26, 2017

@liewegas Please help take a look, thanks.

@@ -95,6 +95,7 @@ enum {
l_filestore_apply_latency,
l_filestore_queue_transaction_latency_avg,
l_filestore_last,
l_filestore_sync_pause_max_lat,

This comment has been minimized.

Copy link
@liewegas

liewegas Jun 26, 2017

Member

this has to go before _last...

This comment has been minimized.

Copy link
@liupan1111

liupan1111 Jun 26, 2017

Author Contributor

Yeah, you are right... but it is so weird it is not segment fault when I ran locally with vstart.sh, I could "perf dump" my new added. Mmm...

Any way, let me fix it.

@liewegas
Copy link
Member

liewegas left a comment

tests break because of the order of the new filestore enum value

src/OSD: add more useful perf counters for performance tuning.
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
@liupan1111

This comment has been minimized.

Copy link
Contributor Author

liupan1111 commented Jun 26, 2017

@liewegas jenkens ok now.

@liewegas liewegas merged commit e57dd54 into ceph:master Jun 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.