New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mgr dashboard #15920

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@wido
Member

wido commented Jun 26, 2017

A few documentation updates for the mgr dashboard

@wido wido added the documentation label Jun 26, 2017

@wido wido requested review from tchaikov and jcsp Jun 26, 2017

@@ -11,5 +11,13 @@ configuration key facility. So we can configure them like::
ceph config-key put mgr/dashboard/$name/server_port $PORT
where ``$name`` is the ID of the ceph-mgr who is hosting this dashboard web app.
If they are not configured, the web app will be bound to ``127.0.0.1:7000``.

This comment has been minimized.

@jcsp

jcsp Jun 26, 2017

Contributor

Do we need to lose the explanation of the default here?

This comment has been minimized.

@wido

wido Jun 26, 2017

Member

Yes, in 015bc3f this was reverted and the manager will throw a RunTimeError when no address has been configured

This comment has been minimized.

@jcsp

jcsp Jun 26, 2017

Contributor

ah, my mistake

@jcsp

jcsp approved these changes Jun 26, 2017

mgr_modules = dashboard
Please note that the dashboard will *only* start on the manager which is active
it that moment. Query the Ceph cluster status to see which manager is active.

This comment has been minimized.

@tchaikov

tchaikov Jun 26, 2017

Contributor

s/it/at/

ceph config-key put mgr/dashboard/server_addr $IP
ceph config-key put mgr/dashboard/server_port $PORT
If the port is not configured, the web app will be bind to ``7000``.

This comment has been minimized.

@tchaikov

tchaikov Jun 26, 2017

Contributor

s/bind/bound/

This comment has been minimized.

@wido

wido Jun 26, 2017

Member

Are you sure it's bound? It's binding to an address, correct? Bound is history, bind is future. Correct?

This comment has been minimized.

@tchaikov

tchaikov Jun 27, 2017

Contributor

yes, i am sure. please see also #15920 (comment).

@@ -33,6 +33,13 @@ Add this to your ceph.conf on nodes where you run ceph-mgr:
If you use any other ceph-mgr modules, make sure they're in the list too.
A address where the dashboard will listen on needs to be configured as well, set this to :: to listen on all

This comment has been minimized.

@tchaikov

tchaikov Jun 26, 2017

Contributor

s/A/An/,

better off quoting the address, like ``::``

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 26, 2017

@wido

This comment has been minimized.

Member

wido commented Jun 27, 2017

@liewegas: Thanks! Fixed that, should be good now?

doc: Mgr Dashboard docs update
More instructions on how to deploy the dashboard using ceph-mgr

Signed-off-by: Wido den Hollander <wido@42on.com>

@liewegas liewegas merged commit 7f3a73b into ceph:master Jun 27, 2017

2 of 4 checks passed

default Build started sha1 is merged.
Details
make check running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment