Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/osd: Non-static class members not initialized in UnsetRedirectOp #15921

Merged

Conversation

Projects
None yet
3 participants
@joscollin
Copy link
Member

commented Jun 26, 2017

Fixes the coverity scan report:

CID 1411830: Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member completion is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member comp is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin jcollin@redhat.com

@joscollin joscollin changed the title test/osd: Non-static class member not initialized in UnsetRedirectOp test/osd: Non-static class members not initialized in UnsetRedirectOp Jun 26, 2017

@joscollin joscollin requested a review from liewegas Aug 12, 2017

@joscollin

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2017

@liewegas Could you please review ? It's been there for a while :-)

@@ -2113,8 +2113,8 @@ class UnsetRedirectOp : public TestOp {
public:
string oid;
librados::ObjectWriteOperation op;
librados::AioCompletion *completion;
librados::AioCompletion *comp;
librados::AioCompletion *completion = nullptr;

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Aug 12, 2017

Member

seems completion is not used and can be safely deleted

test/osd: Non-static class member not initialized in UnsetRedirectOp
Fixes the coverity scan report:
CID 1411830: Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member completion is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member comp is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>

@joscollin joscollin force-pushed the joscollin:wip-CID1411830-Uninitialized-pointer-field branch from b863250 to b1b6688 Aug 12, 2017

@joscollin

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2017

@xiexingguo Done. Please review.
Thanks.

@joscollin joscollin removed the request for review from liewegas Aug 12, 2017

@xiexingguo

This comment has been minimized.

Copy link
Member

commented Aug 12, 2017

retest this please

@joscollin

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2017

@liewegas Could you please merge ? Thanks.

@liewegas liewegas merged commit 5dd89cc into ceph:master Aug 12, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@joscollin joscollin deleted the joscollin:wip-CID1411830-Uninitialized-pointer-field branch Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.