New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: clean up fsstatus module #15925

Merged
merged 5 commits into from Jun 30, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Jun 26, 2017

No description provided.

@jcsp jcsp added the mgr label Jun 26, 2017

@jcsp jcsp requested a review from liewegas Jun 26, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 26, 2017

Can you add a note to the doc/release-notes.rst section enumerating new CLI commands?

@liewegas

otherwise lgtm

@liewegas liewegas added the needs-qa label Jun 27, 2017

@tchaikov tchaikov added the needs-doc label Jun 27, 2017

@tchaikov

lgtm modulo "needs-doc" as Sage commented.

John Spray added some commits Jun 25, 2017

John Spray
pybind/mgr: clean up osd bit of fsstatus.py
Actually implement the bucket filtering argument,
rename the command to "osd status" to deconflict
with existing "osd perf" command.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
pybind/mgr: clean up 'fs status' command
Handle the `fs` argument.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
pybind/mgr: rename fsstatus->status
Still not exactly the best name but
reflects that it isn't just the fs bit.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
common: enable `status` module by default
It's still sort of awkward to prefix these commands
with "mgr tell" but this makes them at least
somewhat accessible to the average user.

Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Jun 27, 2017

Updated PendingReleaseNotes, and also switched on the module by default (otherwise people were not going to be able to actually run the commands without customizing their config)

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 27, 2017

We should add this to qa/workunits/cephtool/test.sh too then?

John Spray
qa: call into `status` module from cephtool test
Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Jun 27, 2017

Added it to the test

@tchaikov tchaikov merged commit 7ee4907 into ceph:master Jun 30, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment