Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: cluster log message on plugin load error #15927

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Projects
None yet
4 participants
@jcsp
Copy link
Contributor

jcsp commented Jun 26, 2017

To make it a bit more obvious what's going on, otherwise
user's first sign is when they try and use a CLI bit
and get a command not found.

Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp added the mgr label Jun 26, 2017

@jcsp jcsp requested a review from tchaikov Jun 26, 2017

@tchaikov tchaikov added the needs-qa label Jun 27, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jun 27, 2017

We should probably turn this into a stick health warning once wip-health merges?

@Liuchang0812
Copy link
Contributor

Liuchang0812 left a comment

it resolves this issue: http://tracker.ceph.com/issues/19913

// Don't drop out here, load the other modules
} else {
// Success!
modules[module_name] = std::move(mod);
}
}

if (!failed_modules.empty()) {
clog->error() << "Failed to load manager modules: " << joinify(

This comment has been minimized.

Copy link
@Liuchang0812

Liuchang0812 Jun 27, 2017

Contributor

@jcsp hi, how about Failed to load MGR modules: "? "manager modules" is not clear

This comment has been minimized.

Copy link
@jcsp

jcsp Jun 27, 2017

Author Contributor

MGR would not be correct (since it's not an acronym), but I've changed it to "ceph-mgr modules" to be completely unambiguous.

John Spray
mgr: cluster log message on plugin load error
To make it a bit more obvious what's going on, otherwise
user's first sign is when they try and use a CLI bit
and get a command not found.

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-mgr-log-on-load-failed branch from c97ad9e to 67bd8c4 Jun 27, 2017

@liewegas liewegas merged commit d6a1335 into ceph:master Jun 30, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.