New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: Execute crush_location_hook when configured in ceph.conf #15951

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Projects
None yet
2 participants
@wido
Member

wido commented Jun 27, 2017

CrushLocation only invoked update_from_conf() which meant that
update_from_hook() was never executed.

By called init_on_startup() both functions are executed so that
the hook is called when configured.

Signed-off-by: Wido den Hollander wido@42on.com

osd: Execute crush_location_hook when configured in ceph.conf
CrushLocation only invoked update_from_conf() which meant that
update_from_hook() was never executed.

By called init_on_startup() both functions are executed so that
the hook is called when configured.

Signed-off-by: Wido den Hollander <wido@42on.com>

@wido wido added the core label Jun 27, 2017

@wido wido added this to the luminous milestone Jun 27, 2017

@wido wido requested a review from liewegas Jun 27, 2017

@wido

This comment has been minimized.

Member

wido commented Jun 27, 2017

There was a refactor of this code since Jewel 6216461

Although that commit says it should also allow for executing hooks it never executes the hook since update_from_hook() is never called by any function.

@liewegas liewegas added the needs-qa label Jun 27, 2017

@wido

This comment has been minimized.

Member

wido commented Jun 28, 2017

Thanks @liewegas for approving the PR! Ran into this with a rather large env where we are testing the RC.

Could this one make it into the next Luminous RC?

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 28, 2017

@liewegas liewegas merged commit 3cd961d into ceph:master Jun 30, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment