New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/filestore/FileStore.cc: remove a redundant judgement when get max latency #15961

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Projects
None yet
4 participants
@majianpeng
Member

majianpeng commented Jun 28, 2017

In fact, utime_t default is utime_t(). So we can remove this judgement.

Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com

@majianpeng

This comment has been minimized.

Member

majianpeng commented Jun 28, 2017

@liupan1111 . Have you time to review this? Thanks!

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jun 28, 2017

@majianpeng This check is used for the first time to compare max_pause_lat and "dur - lat". For the first time, l_filestore_sync_pause_max_lat is not set yet. So I think this check is needed..

@majianpeng

This comment has been minimized.

Member

majianpeng commented Jun 28, 2017

@liupan1111 tget() first return utime_t(). You can see struct perf_counter_data_any_d.

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jun 28, 2017

retest this please

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jun 28, 2017

@majianpeng you are right, I searched the code, and found it would initialize u64(0) in the constructor.

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jun 28, 2017

@majianpeng I prefer to approve after Jenkins happy

os/filestore/FileStore.cc: remove a redundant judgement when get max …
…latency.

In fact, utime_t default is utime_t(). So we can remove this judgement.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@liewegas liewegas merged commit e82ea13 into ceph:master Jun 30, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

@majianpeng majianpeng deleted the majianpeng:filestore-remove-redundant-judgement branch Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment