Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
mon/MonClient: respect the priority in SRV RR #15964
I don't think I like this much. It's transparently passing through the SRV data, but we don't have any way for admins who aren't doing the custom DNS route to configure connections correctly. And why is there both a priority and a weight? I don't mind them exactly but I do see it being confusing for admins -- we could probably just have priorities and randomly select within them and have an interface which is just as useful in practical terms. And I think we should design for our needs and then map the dns options into that instead of designing based on the dns options.
The internal structure stuff all looks fine, of course. :)