New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: register buffer as continuous #15967

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
2 participants
@Adirl

Adirl commented Jun 28, 2017

Signed-off-by: Adir Lev adirl@mellanox.com

@Adirl

This comment has been minimized.

Adirl commented Jun 28, 2017

const auto chunk_end = chunk_base + num_chunk;
for (auto chunk = chunk_base; chunk != chunk_end; chunk++) {
chunk->~Chunk();
}

This comment has been minimized.

@yuyuyu101

yuyuyu101 Jun 28, 2017

Member

I think we could save this. if we add logic to Chunk later, this will preserve we forget to deconstruct

This comment has been minimized.

@Adirl

Adirl Jun 28, 2017

~Chunk() is empty but we can leave it
not on data path anyway

Adir Lev
msg/async/rdma: register buffer as continuous
Change-Id: I1a715de28ace3ff8ae077ca783ad5060e7966d54
Signed-off-by: Adir Lev <adirl@mellanox.com>
@Adirl

This comment has been minimized.

Adirl commented Jun 28, 2017

@yuyuyu101
Done

@yuyuyu101 yuyuyu101 merged commit 7e2e0ad into ceph:master Jun 28, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment