New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: two pool opts related fix #15968

Merged
merged 2 commits into from Jun 30, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Jun 28, 2017

No description provided.

mon/OSDMonitor: fix error handling if we fail to set some pool opts
Returning a positive error code is generally not the preferred option
and can not be handled properly by caller here.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@varadakari

This comment has been minimized.

Contributor

varadakari commented Jun 28, 2017

Changes look good. Could you please add a unit test case to test the unset? May be we can do unset some type and write or try with a new type and read?

os/bluestore: allow user to unset pool compression_mode[algorithm] pr…
…operly

A string-typed pool option requires user pass in a empty string to do a valid cancellation,
but the "osd pool set " command won't allow it. E.g.:
./bin/ceph osd pool set rbd compression_mode
Invalid command:  missing required parameter val(<string>)

Since we already use the "unset" keyword to cancel the csum_type setting,
we could simply extends the above mechanism for compression_mode
and compression_algorithm too.

E.g.:
./bin/ceph osd pool set rbd compression_algorithm zlib
set pool 0 compression_algorithm to zlib

 ./bin/ceph osd pool set rbd compression_algorithm unset
unset pool 0 compression_algorithm

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo requested a review from liewegas Jun 28, 2017

@liewegas liewegas merged commit 7fe8189 into ceph:master Jun 30, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-poolopts-fix branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment