New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: add compression interop to RGW NFS #15989

Merged
merged 3 commits into from Jul 11, 2017

Conversation

Projects
None yet
2 participants
@mattbenjamin
Contributor

mattbenjamin commented Jun 28, 2017

The top commit was needed to test--I think there may be a regression here in building the compression plugins, but apologies if this is operator error.

@mattbenjamin mattbenjamin self-assigned this Jun 28, 2017

@mattbenjamin mattbenjamin requested review from cbodley and aclamk Jun 28, 2017

@aclamk

This comment has been minimized.

Contributor

aclamk commented Jul 5, 2017

@mattbenjamin I had problem with libceph_zlib library. wip_nfs_compress@https://github.com/aclamk/ceph.git addresses it.

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jul 5, 2017

filter = processor;
if (compression_type == "none")

This comment has been minimized.

@aclamk

aclamk Jul 6, 2017

Contributor

compression_type is used only here. Wouldn't be better to remove it from object?

This comment has been minimized.

@mattbenjamin

mattbenjamin Jul 6, 2017

Contributor

@aclamk seems harmless, and is concise

This comment has been minimized.

@mattbenjamin

mattbenjamin Jul 6, 2017

Contributor

@aclamk I guess since I do it every exec_start(), can just be a local

compressor.emplace(s->cct, plugin, filter);
filter = &*compressor;
}
op_ret = put_data_and_throttle(processor, data, ofs, false);

This comment has been minimized.

@aclamk

aclamk Jul 6, 2017

Contributor

Should be:
op_ret = put_data_and_throttle(filter, data, ofs, false);
It seems that we do not have any tests that check for this data path.

This comment has been minimized.

@mattbenjamin

mattbenjamin Jul 6, 2017

Contributor

@aclamk good catch!

@aclamk

This comment has been minimized.

Contributor

aclamk commented Jul 7, 2017

@mattbenjamin I verified that your changes to zlib linking does not affect compression in radosgw. I assume that problems will only show when ceph_globals are defined in loaded so.

@aclamk

aclamk approved these changes Jul 7, 2017

LGTM

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jul 11, 2017

@aclamk , @cbodley I'm guessing I need to rebase this to remove at least the linkage to libglobal, since that appears to have been merged; what about libcommon? If that's not the case, can we merge this now?

@aclamk

This comment has been minimized.

Contributor

aclamk commented Jul 11, 2017

@mattbenjamin After #16245 there is no longer any need to modify linkage.

mattbenjamin added some commits May 4, 2017

rgw_file: enable compression filter (stores)
Previously NFS clients could access compressed data, but the
RGWWriteDataRequest lacked glue to attach an inbound
compression filter.

Fixes: http://tracker.ceph.com/issues/20462

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
rgw_file: compression fix and cleanup from review
A fix and a cleanup from Adam Kupczyk <akupczyk@redhat.com> review.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
rgw_file: add large(ish) write test
allows for read-after-write verify

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jul 11, 2017

@aclamk thanks, updated

@mattbenjamin mattbenjamin merged commit ad71757 into ceph:master Jul 11, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment