Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Data encryption is not follow the AWS agreement #15994

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
5 participants
@chuang-he
Copy link

commented Jun 29, 2017

Encryption request headers should not be sent for GET requests and HEAD
requests if your object uses SSE-KMS/SSE-S3 or you’ll get an HTTP 400
BadRequest error.

http://docs.aws.amazon.com/AmazonS3/latest/dev/KMSUsingRESTAPI.html
http://docs.aws.amazon.com/AmazonS3/latest/dev/SSEUsingRESTAPI.html

Signed-off-by: hechuang hechuang@xsky.com

hechuang
rgw: Data encryption is not follow the AWS agreement
Encryption request headers should not be sent for GET requests and HEAD
requests if your object uses SSE-KMS/SSE-S3 or you’ll get an HTTP 400
BadRequest error.

Signed-off-by: hechuang <hechuang@xsky.com>

@tchaikov tchaikov added the rgw label Jun 29, 2017

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2017

jenkins test this please

@chuang-he

This comment has been minimized.

Copy link
Author

commented Jun 30, 2017

@cbodley @aclamk @Ved-vampir
The pull request(ceph/s3-tests#173) need to merge, Otherwise you won't through s3tests.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2017

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

thanks @yuriw, i'm starting a run that includes ceph/s3-tests#173

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2017

teuthology run was 'successful' in that the only s3test failures were in lifecycle expiration 👍

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2017

ready to merge, but we'll need to coordinate this with ceph/s3-tests#173

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2017

build docs please

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2017

test docs please

@cbodley cbodley merged commit 605c37a into ceph:master Aug 30, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
@theanalyst

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

@cbodley in branch luminous we're seeing s3test failures, I guess we need to backport this fix? http://pulpito.ceph.com/abhi-2017-09-07_16:44:47-rgw-wip-luminous-backports-20170907-distro-basic-smithi/ for eg.

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

@theanalyst it probably is worth backporting, yeah. this also reminds me that we should add a ceph-luminous branch to s3tests, and have the luminous qa suite point to that

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2017

@theanalyst

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

@cbodley sorry didn't see that just backported as #17642

@theanalyst

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

makes sense, lets fwd ceph-master as luminous, as this branch has already passed the teuthology run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.