New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PrimaryLogPG solve cache tier osd high memory consumption #16011

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@hsepeng
Contributor

hsepeng commented Jun 29, 2017

during cache tier dirty data flushing, cache tier osd memroy consumption
will get increasing due to the accumulative pg log which will not be trimmed

Fixes: http://tracker.ceph.com/issues/20464
Fixes: #20464
Signed-off-by: Peng Xie peng.hse@xtaotech.com

@gregsfortytwo

Code looks good, but a few things need to be fixed on the commit message:

What's the #18599 being referenced as a Fix?
Please sign off your commit to indicate you certify appropriate licensing etc on the patch (https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst).

@hsepeng

This comment has been minimized.

Contributor

hsepeng commented Jun 30, 2017

@gregsfortytwo i have updated the fix of the commit message

@liewegas liewegas added the needs-qa label Jun 30, 2017

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jun 30, 2017

FYI we just need the "Fixes: http://tracker.ceph.com/issues/20464" line at this point. We stopped referring to tracker items solely by bug ID because it confuses github and some external bug trackers. :)

osd/PrimaryLogPG solve cache tier osd high memory consumption
during cache tier dirty data flushing, cache tier osd memroy consumption
will get increasing due to the accumulative pg log which will not be trimmed

Fixes: http://tracker.ceph.com/issues/20464

Signed-off-by: Peng Xie <peng.hse@xtaotech.com>
@hsepeng

This comment has been minimized.

Contributor

hsepeng commented Jul 3, 2017

@gregsfortytwo , i have remove the line "Fixes: 20464", thanks.

@tchaikov tchaikov merged commit dadd73f into ceph:master Jul 5, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment