New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd/ceph-mgr: remove automagic mgr creation hack #16023

Merged
merged 1 commit into from Jul 1, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented Jun 29, 2017

For kraken we auto-created mgr daemons next to mon daemons with some
systemd hackery. This is awkward (you can't not get a new mgr daemon when
you deploy a mon), systemd-specific (not implemented for upstart on
trusty), and mostly unexpected. Since ceph-mgr daemons are now first-class
citizens and required for every cluster, make their deployment explicit
and transparent to the administrator. Major upgrades are a rare
opportunity to have the administrator's full attention so take advantage
of it.

This effectively reverts 61d7793 and
082199f (and follow-on fixes).

Fixes/avoids: http://tracker.ceph.com/issues/19994
Signed-off-by: Sage Weil sage@redhat.com

systemd/ceph-mgr: remove automagic mgr creation hack
For kraken we auto-created mgr daemons next to mon daemons with some
systemd hackery.  This is awkward (you can't not get a new mgr daemon when
you deploy a mon), systemd-specific (not implemented for upstart on
trusty), and mostly unexpected.  Since ceph-mgr daemons are now first-class
citizens and required for every cluster, make their deployment explicit
and transparent to the administrator.  Major upgrades are a rare
opportunity to have the administrator's full attention so take advantage
of it.

This effectively reverts 61d7793 and
082199f (and follow-on fixes).

Fixes/avoids: http://tracker.ceph.com/issues/19994
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas added the build/ops label Jun 29, 2017

@jcsp

jcsp approved these changes Jun 29, 2017

@liewegas liewegas added the needs-qa label Jun 29, 2017

@liewegas liewegas merged commit 41677d2 into ceph:master Jul 1, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-19994 branch Jul 1, 2017

tserong added a commit to SUSE/DeepSea that referenced this pull request Jul 5, 2017

Add role-mgr, to deploy ceph-mgr instances
Since ceph/ceph#16023 was merged,
Luminous clusters now all require the explicit deployment of
ceph-mgr daemons.  This commit adds role-mgr to DeepSea, to
allow this.  role-mgr should generally be applied to the same
nodes as role-mon.

Caveats:

- The validate runner now mandates the existence of mgrs, so
  this won't be usable any more against Ceph Jewel and earlier.
- When re-run against an existing Kraken or prerelease Luminous
  cluster (which had autodeployed mgrs), the mgr keyrings
  DeepSea creates will not match the existing keyrings.  The
  user needs to fix this by hand.

Functionality currently missing:

- remove
- rescind
- add mgr support when importing existing clusters.

Fixes: #183
Signed-off-by: Tim Serong <tserong@suse.com>

tserong added a commit to SUSE/DeepSea that referenced this pull request Jul 6, 2017

Add role-mgr, to deploy ceph-mgr instances
Since ceph/ceph#16023 was merged,
Luminous clusters now all require the explicit deployment of
ceph-mgr daemons.  This commit adds role-mgr to DeepSea, to
allow this.  role-mgr should generally be applied to the same
nodes as role-mon.

Caveats:

- The validate runner now mandates the existence of mgrs, so
  this won't be usable any more against Ceph Jewel and earlier.
- When re-run against an existing Kraken or prerelease Luminous
  cluster (which had autodeployed mgrs), the mgr keyrings
  DeepSea creates will not match the existing keyrings.  The
  user needs to fix this by hand.

Functionality currently missing:

- add mgr support when importing existing clusters.

Fixes: #183
Signed-off-by: Tim Serong <tserong@suse.com>

tserong added a commit to SUSE/DeepSea that referenced this pull request Jul 6, 2017

Add role-mgr, to deploy ceph-mgr instances
Since ceph/ceph#16023 was merged,
Luminous clusters now all require the explicit deployment of
ceph-mgr daemons.  This commit adds role-mgr to DeepSea, to
allow this.  role-mgr should generally be applied to the same
nodes as role-mon.

Caveats:

- The validate runner now mandates the existence of mgrs, so
  this won't be usable any more against Ceph Jewel and earlier.
- When re-run against an existing Kraken or prerelease Luminous
  cluster (which had autodeployed mgrs), the mgr keyrings
  DeepSea creates will not match the existing keyrings.  The
  user needs to fix this by hand.

Functionality currently missing:

- remove mgr keys in removal stage
- add mgr support when importing existing clusters.

Fixes: #183
Signed-off-by: Tim Serong <tserong@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment