Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: cls: ceph::timespan tag_timeout wrong units #16026

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@mattbenjamin
Copy link
Contributor

mattbenjamin commented Jun 29, 2017

In rgw_dir_suggest(), the ceph::timespan tag_timeout is intended
to be a value in seconds, but has been taken as something much
smaller (millis?). The incorrect time scale likely induces a race
condition with object deletes.

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

@mattbenjamin mattbenjamin self-assigned this Jun 29, 2017

@mattbenjamin mattbenjamin requested review from yehudasa and cbodley Jun 29, 2017

rgw: cls: ceph::timespan tag_timeout wrong units
In rgw_dir_suggest(), the ceph::timespan tag_timeout is intended
to be a value in seconds, but has been taken as something much
smaller (millis?).  The incorrect time scale likely induces a race
condition with object deletes.

Fixes: http://tracker.ceph.com/issues/20380

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@mattbenjamin

This comment has been minimized.

Copy link
Contributor Author

mattbenjamin commented Jun 29, 2017

(will add "Fixes: http://tracker.ceph.com/issues/20380" if it...does)

@cbodley
Copy link
Contributor

cbodley left a comment

looks good. the default is nanoseconds: typedef std::chrono::duration<rep, std::nano> timespan;

@yehudasa
Copy link
Member

yehudasa left a comment

lgtm

@mattbenjamin mattbenjamin force-pushed the linuxbox2:wip-tag-timeout-secs branch from 5c29054 to e6763eb Jun 29, 2017

@prallabh

This comment has been minimized.

Copy link
Contributor

prallabh commented Jun 30, 2017

@yehudasa yehudasa merged commit 0805115 into ceph:master Jul 5, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

dongbula added a commit to dongbula/ceph that referenced this pull request Jul 22, 2017

Merge pull request ceph#16026 from linuxbox2/wip-tag-timeout-secs
    rgw: cls: ceph::timespan tag_timeout wrong units

    Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.