New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/mgr: add detail error infomation #16048

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@Yan-waller
Contributor

Yan-waller commented Jun 30, 2017

if we add a command such as mgr dump_stats in MGR DaemonServer, then we upgrade ceph from jewel to luminous or later, and require-osd-release has not set to luminous , then we get the following errors:

[root@control01 rpm]# ceph mgr dump_stats 
Error ENOSYS: 
[root@control01 rpm]# 

that's because of require-osd-release < luminous , MGR flag of the commands in MgrCommands.h will be hidden, and Command will be sent to mon but mgr.

[root@control01 rpm]# ceph mgr dump_stats
Error ENOSYS: Command 'mgr dump_stats' not implemented!
[root@control01 rpm]# 

Signed-off-by: Yan Jun yan.jun8@zte.com.cn

mon/mgr: add detail error infomation
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
@Yan-waller

This comment has been minimized.

Contributor

Yan-waller commented Jul 1, 2017

retest this please

@jcsp

jcsp approved these changes Jul 3, 2017

@liewegas liewegas merged commit 294756e into ceph:master Jul 5, 2017

5 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment