New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: dev: add notes on PR make check validation test #16079

Merged
merged 3 commits into from Jul 9, 2017

Conversation

Projects
None yet
2 participants
@smithfarm
Contributor

smithfarm commented Jul 3, 2017

No description provided.

smithfarm added some commits Jul 3, 2017

doc: dev: add notes on PR make check test
Signed-off-by: Nathan Cutler <ncutler@suse.com>
doc: dev: change "make check" into an internal Xref
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm requested a review from Jul 3, 2017

@ghost

ghost approved these changes Jul 3, 2017

* Find the corresponding source code
* Writing `make check`_ tests
* Caveats
1. The tests in `make check`_ are not linked against libtcmalloc by default,

This comment has been minimized.

@tchaikov

tchaikov Jul 4, 2017

Contributor

better off putting

Unlike ceph daemons and ceph-fuse, the unit tests are always linked against the default glibc allocator.

otherwise we need to enumerate all supported allocators (for instance, jemalloc, tcmalloc_minimal) here.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 4, 2017

@tchaikov Please take a look at the commit I just added.

1. Unlike the various Ceph daemons and ``ceph-fuse``, the `make check`_ tests
are linked against the default memory allocator (glibc) unless explicitly
linked against something else. This enables tools like valgrind to be used
in the tests.

This comment has been minimized.

@tchaikov

tchaikov Jul 4, 2017

Contributor

yeah, much better than my version!

doc: dev: unit tests are not linked against tcmalloc
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 9, 2017

test this please

@smithfarm smithfarm merged commit b08b485 into ceph:master Jul 9, 2017

3 of 4 checks passed

make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-doc-make-check branch Jul 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment