New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: move object exist in assign nid #16117

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@majianpeng
Member

majianpeng commented Jul 5, 2017

a)avoid repeatedly set if object exist
b)remove code simple

@majianpeng

This comment has been minimized.

Show comment
Hide comment
@majianpeng

majianpeng Jul 5, 2017

Member

@tchaikov . Recreate

Member

majianpeng commented Jul 5, 2017

@tchaikov . Recreate

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Jul 5, 2017

Contributor

this PR was posted as #16065, and was closed unintentionally.

Contributor

tchaikov commented Jul 5, 2017

this PR was posted as #16065, and was closed unintentionally.

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 5, 2017

Member

The bluestore change looks good.

Member

xiexingguo commented Jul 5, 2017

The bluestore change looks good.

@majianpeng

This comment has been minimized.

Show comment
Hide comment
@majianpeng

majianpeng Jul 5, 2017

Member

@xiexingguo . remove kstore part by your suggestion.

Member

majianpeng commented Jul 5, 2017

@xiexingguo . remove kstore part by your suggestion.

@xiexingguo xiexingguo changed the title from Bluestore move object exist in assign nid to os/bluestore: move object exist in assign nid Jul 5, 2017

@xiexingguo xiexingguo added the needs-qa label Jul 5, 2017

@tchaikov tchaikov requested a review from liewegas Jul 5, 2017

@tchaikov tchaikov merged commit 1f47aff into ceph:master Jul 5, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
os/bluestore/BlueStore: move "onode::exists=true" in _assign_nid.
If object  has nid, it always set exists =true in get_onode.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@majianpeng majianpeng deleted the majianpeng:bluestore-move-object-exist-in-assign-nid branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment