New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: don't activate suppressed journal devices #16123

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
3 participants
@ddiss
Contributor

ddiss commented Jul 5, 2017

Multipath device activation currently requires that devices representing
individual paths making up a multipath device are suppressed, to avoid
errors such as:
ceph_disk.main.Error: Error: /dev/sda1 is not a multipath block device

Activation of suppressed OSD devices is currently handled by checks in
main_activate() and main_activate_space(). However, suppressed journal
and block devices are not detected.

(Along with udev change) Fixes: http://tracker.ceph.com/issues/19489

Signed-off-by: David Disseldorp ddiss@suse.de

ceph-disk: don't activate suppressed journal devices
Multipath device activation currently requires that devices representing
individual paths making up a multipath device are suppressed, to avoid
errors such as:
  ceph_disk.main.Error: Error: /dev/sda1 is not a multipath block device

Activation of suppressed OSD devices is currently handled by checks in
main_activate() and main_activate_space(). However, suppressed journal
and block devices are not detected.

(Along with udev change) Fixes: http://tracker.ceph.com/issues/19489

Signed-off-by: David Disseldorp <ddiss@suse.de>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 20, 2017

i will take a look tmr.

@tchaikov tchaikov self-assigned this Jul 20, 2017

@tchaikov tchaikov merged commit 6ce96c7 into ceph:master Jul 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@ddiss ddiss deleted the ddiss:fix-journal-supression branch Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment