New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: drop unused rgw_pool parameter, local variables and member variable #16154

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@mikulely
Contributor

mikulely commented Jul 6, 2017

This pr contains:

  • drop unused rgw_pool parameter in get_raw_obj_ref() and get_system_obj_ref(), because each method needs a rgw_raw_obj as param which includes its own rgw_pool.
  • drop misc unused local vars rgw_pool
  • drop member variable pool

@mattbenjamin @yehudasa mind to take a look? It's continuation part after RFC rgw: bucket placement cleanup #15797

@mikulely

This comment has been minimized.

Contributor

mikulely commented Jul 6, 2017

Jenkins, retest this please.

@joscollin joscollin changed the title from rgw: object placement cleanup - get_obj_ref part to rgw: drop unused rgw_pool parameter, local variables and member variable Jul 8, 2017

@joscollin

LGTM.

You can squash the commits into one now. The PR Title and PR Description are corrected by me. You can copy paste them as Commit Title and its Description.

@joscollin joscollin added the needs-qa label Jul 8, 2017

rgw: drop unused rgw_pool param, local var and member var
+ drop unused rgw_pool parameter in get_raw_obj_ref() and
  get_system_obj_ref(), because each method needs a rgw_raw_obj as
  param which includes its own rgw_pool.
+ drop misc unused local vars rgw_pool.
+ drop member variable pool.

Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
@mikulely

This comment has been minimized.

Contributor

mikulely commented Jul 10, 2017

Thanks @joscollin for your attention, repushed.

@yuriw

This comment has been minimized.

@yuriw yuriw merged commit dba56d6 into ceph:master Jul 12, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@mikulely mikulely deleted the mikulely:obj-placement-pool branch Jul 13, 2017

@mikulely

This comment has been minimized.

Contributor

mikulely commented Jul 13, 2017

Thanks @joscollin @yuriw for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment