New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "os/filestore: move ondisk in front, so that return oncommit e… #16156

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Jul 6, 2017

…arlier, and improve write op performance."

This reverts commit 21f167c.

Fixes: http://tracker.ceph.com/issues/20524
Signed-off-by: Kefu Chai kchai@redhat.com

Revert "os/filestore: move ondisk in front, so that return oncommit e…
…arlier, and improve write op performance."

This reverts commit 21f167c.

Fixes: http://tracker.ceph.com/issues/20524
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and liupan1111 Jul 6, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 6, 2017

see also #13918

@tchaikov

This comment has been minimized.

@tchaikov tchaikov added this to the luminous milestone Jul 6, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jul 6, 2017

@tchaikov thanks. since my change makes one test case failed, I agree to revert it first. Could you tell me how to run This failed case locally? I want to investigate.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 6, 2017

@liupan1111 i failed to reproduce it locally. but i have it reproduced with this test consistently in sepia. probably you can check the log for further investigation.

@tchaikov tchaikov requested a review from jdurgin Jul 6, 2017

@tchaikov tchaikov merged commit f4d602b into ceph:master Jul 6, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-20524 branch Jul 6, 2017

@wangzhengyong

This comment has been minimized.

Contributor

wangzhengyong commented Jul 7, 2017

@tchaikov could you do me a favor how we can check the osd log? i only can see the teuthology log

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 7, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 7, 2017

@wangzhengyong, for instance, you can have one of the osd logs at

http://qa-proxy.ceph.com/teuthology/kchai-2017-07-06_01:46:58-rados-master-distro-basic-smithi/1364989/remote/smithi137/log/ceph-osd.1.log.gz

which has follow bt

 ceph version 12.0.3-2564-g0805115 (08051155a4e09b75649d59edc16d069119cc0d6e) luminous (rc)
 1: (()+0x9f03d1) [0xaf83d1]
 2: (()+0xf370) [0xc7ec370]
 3: (gsignal()+0x37) [0xd6691d7]
 4: (abort()+0x148) [0xd66a8c8]
 5: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x284) [0xb36274]
 6: (Mutex::Lock(bool)+0x1a4) [0xb169e4]
 7: (FileStore::_journaled_ahead(FileStore::OpSequencer*, FileStore::Op*, Context*)+0x14a) [0x90118a]
 8: (Context::complete(int)+0x9) [0x607fb9]
 9: (Finisher::finisher_thread_entry()+0x198) [0xb33a58]
 10: (()+0x7dc5) [0xc7e4dc5]
 11: (clone()+0x6d) [0xd72b76d]
@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jul 10, 2017

@tchaikov I didn't have any clue yet... I think we should at least dump the error before "assert" failure... I will continue investigate.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 10, 2017

@liupan1111 please define "the error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment