New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: differ default cache size for hdd/ssd backends #16157

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
5 participants
@xiexingguo
Member

xiexingguo commented Jul 6, 2017

This is a follow-up change of #15976
and makes the bluestore cache capacity self-adaptive for different backends.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

Show outdated Hide outdated src/common/config_opts.h Outdated

@ifed01 ifed01 added the bluestore label Jul 6, 2017

@xiaoxichen

This comment has been minimized.

Show comment
Hide comment
@xiaoxichen

xiaoxichen Jul 6, 2017

Contributor

We shoud update the document about memory consumption estimation for an OSD.

Cache can eat up 3GB/1GB
RocksDB write buffer eat up 256MB * 4 = 1GB.
RocksDB internal and buffer for compaction ??
Other Code/Recovery = 2GB extra

Looks like the number would be 7 - 8GB per NVMe Drive , or 5 - 6GB for HDD drive.

Not sure how community deploy their OSD, but at least we(ebay) is far from such memory/hdd ratio.

Contributor

xiaoxichen commented Jul 6, 2017

We shoud update the document about memory consumption estimation for an OSD.

Cache can eat up 3GB/1GB
RocksDB write buffer eat up 256MB * 4 = 1GB.
RocksDB internal and buffer for compaction ??
Other Code/Recovery = 2GB extra

Looks like the number would be 7 - 8GB per NVMe Drive , or 5 - 6GB for HDD drive.

Not sure how community deploy their OSD, but at least we(ebay) is far from such memory/hdd ratio.

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 6, 2017

Member

retest this please

Member

xiexingguo commented Jul 6, 2017

retest this please

@xiexingguo xiexingguo requested a review from liewegas Jul 6, 2017

@markhpc

This comment has been minimized.

Show comment
Hide comment
@markhpc

markhpc Jul 6, 2017

Member

High Xiexingguo, you might want to review #15786 as it just needs a minor change before it merges. I think your PR is complementary but will need a rebase.

Member

markhpc commented Jul 6, 2017

High Xiexingguo, you might want to review #15786 as it just needs a minor change before it merges. I think your PR is complementary but will need a rebase.

@markhpc markhpc added the performance label Jul 6, 2017

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 6, 2017

Member

High Xiexingguo, you might want to review #15786 as it just needs a minor change before it merges. I think your PR is complementary but will need a rebase.

@markhpc Hi, mark. Feel free to merge #15786, will rebase once it gets merged:-)

Member

xiexingguo commented Jul 6, 2017

High Xiexingguo, you might want to review #15786 as it just needs a minor change before it merges. I think your PR is complementary but will need a rebase.

@markhpc Hi, mark. Feel free to merge #15786, will rebase once it gets merged:-)

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 7, 2017

Member

retest this please

Member

xiexingguo commented Jul 7, 2017

retest this please

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 7, 2017

Member

@liewegas Mind getting this one into Luminous too? It's important for normal(hdd) users...

Member

xiexingguo commented Jul 7, 2017

@liewegas Mind getting this one into Luminous too? It's important for normal(hdd) users...

@liewegas liewegas added this to the luminous milestone Jul 7, 2017

os/bluestore: differ default cache size for hdd/ssd backends
This is a follow-up change of #15976
and makes the bluestore cache capacity being self-adaptive for
different backends.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
cache_meta_ratio = cct->_conf->bluestore_cache_meta_ratio;
cache_kv_ratio = cct->_conf->bluestore_cache_kv_ratio;
double cache_size = cct->_conf->bluestore_cache_size;

This comment has been minimized.

@xiexingguo

xiexingguo Jul 7, 2017

Member

@liewegas Sorry, resolved a conflict with Mark's PR #15786 just now.
Also fix a typo introduced by that PR.
Do you mind reloading this into the testing branch?

@xiexingguo

xiexingguo Jul 7, 2017

Member

@liewegas Sorry, resolved a conflict with Mark's PR #15786 just now.
Also fix a typo introduced by that PR.
Do you mind reloading this into the testing branch?

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 7, 2017

Member

retest this please

Member

xiexingguo commented Jul 7, 2017

retest this please

@liewegas liewegas merged commit e46f131 into ceph:master Jul 7, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-bluestore-cache branch Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment