New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: use bufferlist functions whenever possible #16158

Merged
merged 3 commits into from Jul 11, 2017

Conversation

Projects
None yet
4 participants
@majianpeng
Member

majianpeng commented Jul 6, 2017

In fact, bufferlist already have the same function functions, etc prepend_zero, claim_prepend. So replace the related codes with those functions.
@ifed01 . For 1fa1c39 i'm not sure. But from the current code, i think it can remove the original bufferlist. Or maybe am i missing something? Thanks!

@ifed01

ifed01 approved these changes Jul 6, 2017

LGTM

@ifed01 ifed01 changed the title from Bluestore using bufferlist function do the same function to os/bluestore: use bufferlist functions whenever possible Jul 6, 2017

majianpeng added some commits Jul 6, 2017

os/bluestore/BlueStore:using prepend_zero replace related code.
In bufferlist::prepend_zero do the same thing:
    bufferlist z;
    z.append_zero(head_pad);
    z.claim_append(padded);
    padded.claim(z);

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
os/bluestore/BlueStore: using claim_prepend replace related code.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
os/bluestore/BlueStore: remove useless parameter.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@tchaikov tchaikov added the needs-qa label Jul 10, 2017

@liewegas liewegas merged commit 42d811d into ceph:master Jul 11, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment