jewel: cephfs: Journaler may execute on_safe contexts prematurely #16192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This asserted that flush_pos would be ahead of safe_pos after calling _flush. However, this is not guaranteed to be the case because prezeroing might prevent us from flushing right now. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 58ec1c6)
Signed-off-by: "Yan, Zheng" <zyan@redhat.com> (cherry picked from commit 41618d8)
smithfarm
changed the title
|
Hmm, I can't remember how bad the issue was that needed the followup commit: @ukernel ? |
|
it's better to also cherry pick 146383a. |
|
The whole series fix an issue in purge queue. we haven't back-ported purge queue to jewel. So another option is reverting #15468 |
|
the bug can cause damaged mds. it should be blocker for 10.2.8. |
|
Since we tend towards not backporting features, and the purge queue sounds like a feature, I propose the following course of action:
Alternatively, we could cherry-pick 146383a into this PR, merge it, and cut a 10.2.9 with this PR? |
smithfarm
added a commit
to smithfarm/ceph
that referenced
this pull request
Jul 12, 2017
See the discussion in ceph#16192 Signed-off-by: Nathan Cutler <ncutler@suse.com>
|
http://tracker.ceph.com/issues/20536 was rejected |
smithfarm
added a commit
to smithfarm/ceph
that referenced
this pull request
Jul 13, 2017
See the discussion in ceph#16192 Signed-off-by: Nathan Cutler <ncutler@suse.com>
dmick
pushed a commit
to dmick/ceph
that referenced
this pull request
Jul 18, 2017
See the discussion in ceph#16192 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/20536