Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg: QueueStrategy::wait() joins all threads #16194

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@cbodley
Copy link
Contributor

cbodley commented Jul 6, 2017

wait() was only looping over disp_threads, which is an intrusive list
that only contains threads that are waiting on a message from
ds_dispatch(). this means that some QSThreads could outlive the
QueueStrategy itself, causing a segfault in QueueStrategy::entry()

Fixes: http://tracker.ceph.com/issues/20534

msg: QueueStrategy::wait() joins all threads
wait() was only looping over disp_threads, which is an intrusive list
that only contains threads that are waiting on a message from
ds_dispatch(). this means that some QSThreads could outlive the
QueueStrategy itself, causing a segfault in QueueStrategy::entry()

Fixes: http://tracker.ceph.com/issues/20534

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley requested a review from mattbenjamin Jul 6, 2017

@mattbenjamin
Copy link
Contributor

mattbenjamin left a comment

looks good

@liewegas liewegas added the needs-qa label Jul 7, 2017

@liewegas liewegas added this to the luminous milestone Jul 7, 2017

@liewegas liewegas merged commit 5caf528 into ceph:master Jul 7, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-20534 branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.