New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: Fix undefined FIRST_ARG #16208

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@b-ranto
Contributor

b-ranto commented Jul 7, 2017

If FIRST_ARG is undefined, the rpms will show an error on upgrade
because the condition in the postun script gets broken.

Signed-off-by: Boris Ranto branto@redhat.com

@b-ranto b-ranto requested a review from smithfarm Jul 7, 2017

@smithfarm

You might mention in the commit message that the current behavior is a regression introduced by 6991764

rpm: Fix undefined FIRST_ARG
If FIRST_ARG is undefined, the rpms will show an error on upgrade
because the condition in the postun script gets broken.

This was a regression introduced by commit for issue 20077 that moved
ceph-disk unit files to ceph-base.

Fixes: http://tracker.ceph.com/issues/20077
Signed-off-by: Boris Ranto <branto@redhat.com>
@b-ranto

This comment has been minimized.

Contributor

b-ranto commented Jul 7, 2017

Yeah, I have amended the commit message and added a Fixes line for the issue that introduced it to avoid creating three more tracker issues (two of them backports).

@b-ranto b-ranto merged commit 07b2e36 into master Jul 7, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@b-ranto

This comment has been minimized.

Contributor

b-ranto commented Jul 7, 2017

Merged, I will add the commit to the backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment