New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy #16221

Merged
merged 5 commits into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 7, 2017

Fixes: http://tracker.ceph.com/issues/20546
Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added this to the luminous milestone Jul 10, 2017

@liewegas liewegas changed the title from crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy to DNM crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy Jul 10, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 11, 2017

rebase and merge after #15643

@liewegas liewegas changed the title from DNM crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy to crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy Jul 12, 2017

@liewegas liewegas added the needs-qa label Jul 12, 2017

@liewegas liewegas requested a review from neha-ojha Jul 12, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 13, 2017

retest this please

@liewegas liewegas changed the title from crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy to DNM crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy Jul 13, 2017

liewegas added some commits Jul 11, 2017

osd/OSDMap: whitespace
Signed-off-by: Sage Weil <sage@redhat.com>
osd/OSDMap: remove assumption about type ids
The code is assuming type==1 is in use, but it might not be.  (It is
usually 'chassis' by default, which is rarely used; 'host' is type usually
type 2.)  Remove the type check entirely and identify leaves by a child
>= 0.

Signed-off-by: Sage Weil <sage@redhat.com>
osdmaptool: add --health option
Generate and dump health checks.

Signed-off-by: Sage Weil <sage@redhat.com>
@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jul 13, 2017

Is this still in progress or ready for review?

@liewegas liewegas changed the title from DNM crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy to crush/CrushWrapper: make get_immediate_parent[_id] ignore per-class shadow hierarchy Jul 13, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 13, 2017

ready for review. in my latest testing branch.

@liewegas liewegas requested a review from gregsfortytwo Jul 14, 2017

@liewegas liewegas merged commit d52763c into ceph:master Jul 14, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-20546 branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment