New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/mgr/dashboard: bind to :: by default #16223

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 7, 2017

This is all available v4 and v6 addrs on the host.

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added the mgr label Jul 7, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 7, 2017

Since we now have an explict 'ceph mgr module enable dashboard' step it is safe to default to bind to :: (all addresses on the host). Combined with the default port of 7000 means we have a single command to turn on the dashboard.

@liewegas liewegas requested review from dmick and jcsp Jul 7, 2017

@@ -744,7 +744,7 @@ def mds_counters(self, fs_id):
return dict(result)
server_addr = self.get_localized_config('server_addr')
server_addr = self.get_localized_config('server_addr') or '::'

This comment has been minimized.

@tchaikov

tchaikov Jul 8, 2017

Contributor

could just put

server_addr = self.get_localized_config('server_addr', '::')
pybind/mgr/dashboard: bind to :: by default
This is all available v4 and v6 addrs on the host.

Signed-off-by: Sage Weil <sage@redhat.com>

@tchaikov tchaikov added the needs-qa label Jul 9, 2017

@liewegas liewegas merged commit 7f22400 into ceph:master Jul 10, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-dashboard-default branch Jul 10, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Jul 10, 2017

This probably makes Wido's recent doc changes out of date again (the part about where it listens by default was removed)

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 10, 2017

see #16241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment