New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr,os,test: kill clang analyzer warnings #16227

Merged
merged 4 commits into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jul 8, 2017

No description provided.

tchaikov added some commits Jul 8, 2017

mgr/PyState: fix leak if `type` is unknown
this silences a clang analyzer warning:

Potential leak of memory pointed to by 'c'

Signed-off-by: Kefu Chai <kchai@redhat.com>
os/bluestore: do not assign to never-read variable
this silences the clang analyzer warnings like:

Value stored to 'p' is never read

Signed-off-by: Kefu Chai <kchai@redhat.com>
test/libradosstriper: always free allocated memory
use unique_ptr to manage allocated memory, so we can free it even if the
test fails. this silences the warnings like:

Potential leak of memory pointed to by 'buf2'

Signed-off-by: Kefu Chai <kchai@redhat.com>
test/ceph_test_librgw_file_nfsns: always free allocated memory
use unique_ptr to manage allocated memory, so we can free it even if the
test fails. this silences the warnings like:

Potential leak of memory pointed to by 'buf2'

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from badone Jul 8, 2017

@badone

badone approved these changes Jul 10, 2017

LGTM

@tchaikov tchaikov added the needs-qa label Jul 10, 2017

@liewegas liewegas changed the title from Wip kill clang analyzer warnings to mgr,os,test: kill clang analyzer warnings Jul 10, 2017

@liewegas liewegas merged commit 8e5c730 into ceph:master Jul 11, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-kill-clang-analyzer-warnings branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment