New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix rados/upgrade/jewel-x-singleton and make workunit task handle repo URLs not ending in ".git" #16228

Merged
merged 2 commits into from Jul 9, 2017

Conversation

Projects
None yet
2 participants
@smithfarm
Contributor

smithfarm commented Jul 8, 2017

qa/suites/rados/upgrade: upgrade client.0 node too
Fixes: http://tracker.ceph.com/issues/20368
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm requested review from liewegas and cbodley Jul 8, 2017

qa: workunit: handle repo ending in "/ceph-ci"
If the repo ends in "/ceph-ci" it's the same as if it ended in "/ceph-ci.git"

Before this change, the following command was broken if the workunit specified,
e.g., "branch: jewel":

teuthology-suite --ceph-repo https://github.com/ceph/ceph --ceph master
--suite-repo https://github.com/ceph/ceph-ci --suite-branch wip-foo . . .

Fixes: http://tracker.ceph.com/issues/20554
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 8, 2017

Tested once with: teuthology-suite -k distro --machine-type smithi --priority 101 --email ncutler@suse.com --ceph-repo https://github.com/ceph/ceph --ceph master --suite-repo https://github.com/ceph/ceph-ci --suite-branch wip-rados-upgrade-2 --suite rados/upgrade/jewel-x-singleton

pass http://pulpito.ceph.com/smithfarm-2017-07-08_08:55:21-rados:upgrade:jewel-x-singleton-master-distro-basic-smithi/

But then I tweaked the commits, so testing again with: teuthology-suite -k distro --machine-type smithi --priority 101 --email ncutler@suse.com --ceph-repo https://github.com/ceph/ceph --ceph master --suite-repo https://github.com/smithfarm/ceph --suite-branch wip-rados-upgrade-2 --suite rados/upgrade/jewel-x-singleton --newest 10

pass http://pulpito.front.sepia.ceph.com:80/smithfarm-2017-07-08_17:09:57-rados:upgrade:jewel-x-singleton-master-distro-basic-smithi/

@smithfarm smithfarm changed the title from tests: fix rados/upgrade/jewel-x-singleton to tests: fix rados/upgrade/jewel-x-singleton and make workunit handle repo URLs not ending in ".git" Jul 8, 2017

@smithfarm smithfarm changed the title from tests: fix rados/upgrade/jewel-x-singleton and make workunit handle repo URLs not ending in ".git" to tests: fix rados/upgrade/jewel-x-singleton and make workunit task handle repo URLs not ending in ".git" Jul 8, 2017

@liewegas liewegas merged commit 0c79c4f into ceph:master Jul 9, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-rados-upgrade-2 branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment