New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/ceph.py: no osd id to 'osd create' command #16233

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jul 9, 2017

This isn't recognized by hammer, and we don't need it for jewel.

Fixes: http://tracker.ceph.com/issues/20548
Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added this to the luminous milestone Jul 9, 2017

@tchaikov

aside from the comment, lgtm.

@@ -1129,15 +1129,14 @@ def run_daemon(ctx, config, type_):
]
)
except:
# fallback to pre-luminous
# fallback to pre-luminous (hammer or jewel)

This comment has been minimized.

@tchaikov

tchaikov Jul 10, 2017

Contributor

jewel supports id parameter also.

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 10, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 10, 2017

ahh, right. was looking at "ceph osd create".

@tchaikov

lgtm after rebase.

@tchaikov tchaikov added the needs-qa label Jul 10, 2017

qa/tasks/ceph.py: no osd id to 'osd create' command
This isn't recognized by hammer, and we don't need it for jewel.

Fixes: http://tracker.ceph.com/issues/20548
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 0351dc3 into ceph:master Jul 10, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-osd-create branch Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment